On Wed, Sep 20, 2017 at 5:12 AM, Steve Loughran <ste...@hortonworks.com> wrote:
> > > > > What we could do is have a patch submission process which says "if you are > playing with packaging, you must declare at the time of patch submission > that you have run a full mvn clean install". And a commit process which > says "if you commit a patch which changes the packaging, you need to do a > build before a test" > > This is a variant of what we expect for the hadoop-aws and hadoop-azure > clients where the submitter has to state the endpoint they ran the > integration test suite against. Committer is expected to rerun the test > suite locally before the commit too, for safety > > And we should all be trying 'mvn package -Pdist,native" regularly too, and > playing with the new scripts. We need to find the issues before anyone else > > For all this to work, of course, we need reproducible builds. I see my > mornings build is asking for "json-smart-2.3-SNAPSHOT.pom" as well as the > doxia stuff. Why is so much -SNAPSHOT stuff getting in? I don't even see a > ref for json-smart in our POMs For stability of packaging changes, we could also ask commiters to include in relevant commits a piece of commit metadata in the message that we issue from a jenkins job, i.e. give the job a patch and run full nightly QBT against tree with the patch in place. -- busbey
