+1 (Binding). Haven't thoroughly reviewed all the new code but successfully ran all the integration and unit tests today. Based on the progress this looks ready to merge. Good work folks.
On Wed, Sep 19, 2018 at 5:19 PM John Zhuge <john.zh...@gmail.com> wrote: > +1 (Binding) Nice effort all around. > > On Tue, Sep 18, 2018 at 2:45 AM Steve Loughran <ste...@hortonworks.com> > wrote: > > > +1 (Binding) > > > > Ive been testing this; the current branch is rebased to trunk and all the > > new tests are happy. > > > > > > the connector is as good as any of the connectors get before they are > > ready for people to play with: there are always surprises in the wild, > > usually network and configuration —those we have to wait and see what > > happens, > > > > > > > > > > > > > > > On 18 Sep 2018, at 04:10, Sean Mackrory <mackror...@gmail.com> wrote: > > > > > > All, > > > > > > I would like to propose that HADOOP-15407 be merged to trunk. As > > described > > > in that JIRA, this is a complete reimplementation of the current > > > hadoop-azure storage driver (WASB) with some significant advantages. > The > > > impact outside of that module is very limited, however, and it appears > > that > > > on-going improvements will continue to be so. The tests have been > stable > > > for some time, and I believe we've reached the point of being ready for > > > broader feedback and to continue incremental improvements in trunk. > > > HADOOP-15407 was rebased on trunk today and I had a successful test > run. > > > > > > I'd like to call out the contributions of Thomas Marquardt, Da Zhou, > and > > Steve > > > Loughran who have all contributed significantly to getting this branch > to > > > its current state. Numerous other developers are named in the commit > log > > > and the JIRA. > > > > > > I'll start us off: > > > > > > +1 (binding) > > > > > > -- > John >
