Steve Loughran created HADOOP-16218:
---------------------------------------
Summary: findbugs warning of null param to non-nullable method in
Configuration with Guava update
Key: HADOOP-16218
URL: https://issues.apache.org/jira/browse/HADOOP-16218
Project: Hadoop Common
Issue Type: Sub-task
Components: build
Affects Versions: 3.3.0
Reporter: Steve Loughran
Assignee: Steve Loughran
Findbugs is fussing over some unchanged code in configuration
{code}
Null passed for non-null parameter of writeXml(String, Writer) in
org.apache.hadoop.conf.Configuration.writeXml(Writer)
Bug type NP_NULL_PARAM_DEREF_ALL_TARGETS_DANGEROUS (click for details)
In class org.apache.hadoop.conf.Configuration
In method org.apache.hadoop.conf.Configuration.writeXml(Writer)
Called method org.apache.hadoop.conf.Configuration.writeXml(String, Writer)
At Configuration.java:[line 3490]
Argument 1 is definitely null but must not be null
Definite null passed to dangerous method call target
org.apache.hadoop.conf.Configuration.writeXml(String, Writer)
{code}
Code looks fine; it's invoking Guava.Strings for the check for string ==
empty-or-null; maybe something changed there.
Proposed: add @Nullable in Configuration writeXml
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org
