this is a silly question, but what is a "Junit 5 test"? We've been slowly adopting the assertJ APIs in new tests in hadoop-aws, and they work file in the older codebase, so even for existing tests we can advocate them. they're very good for making assertions about collections; very verbose for classic assertTrue/assertFalse, but can be used to generate great error strings
On Fri, Jul 26, 2019 at 9:26 AM Akira Ajisaka <aajis...@gmail.com> wrote: > Hi folks, > > Now we are slowly migrating from JUnit4 to JUnit5. > https://issues.apache.org/jira/browse/HADOOP-14693 > > However, as Steve commented [1], if we are going to migrate the > existing tests, the backporting cost will become too expensive. > Therefore, I'd like to recommend using JUnit5 for new tests before > migrating the existing tests. Using junit-vintage-engine, we can mix > JUnit4 and JUnit5 APIs in the same module, so writing new tests in > JUnit5 is relatively easy. > > Any thoughts? > > [1] > https://issues.apache.org/jira/browse/HADOOP-16318?focusedCommentId=16890955&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16890955 > > -Akira > > --------------------------------------------------------------------- > To unsubscribe, e-mail: mapreduce-dev-unsubscr...@hadoop.apache.org > For additional commands, e-mail: mapreduce-dev-h...@hadoop.apache.org > >