vinayakumarb commented on a change in pull request #8: URL: https://github.com/apache/hadoop-thirdparty/pull/8#discussion_r492866355
########## File path: hadoop-shaded-guava/pom.xml ########## @@ -0,0 +1,110 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. +--> +<project xmlns="http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <parent> + <artifactId>hadoop-thirdparty</artifactId> + <groupId>org.apache.hadoop.thirdparty</groupId> + <version>1.1.0-SNAPSHOT</version> + <relativePath>..</relativePath> + </parent> + <modelVersion>4.0.0</modelVersion> + <artifactId>hadoop-shaded-guava</artifactId> + <name>Apache Hadoop shaded Guava</name> + <packaging>jar</packaging> + + <dependencies> + <dependency> + <groupId>com.google.guava</groupId> + <artifactId>guava</artifactId> + <version>${guava.version}</version> + <exclusions> + <!-- Excluding error_prone_annotations because of YARN-10195--> + <exclusion> + <groupId>com.google.errorprone</groupId> + <artifactId>error_prone_annotations</artifactId> + </exclusion> + </exclusions> + </dependency> + </dependencies> + + <build> + <resources> + <resource> + <directory>${project.basedir}/..</directory> + <targetPath>META-INF</targetPath> + <includes> + <include>licenses-binary/*</include> + <include>NOTICE.txt</include> + <include>NOTICE-binary</include> + </includes> + </resource> + <resource> + <directory>${project.basedir}/src/main/resources</directory> + </resource> + </resources> + <plugins> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-shade-plugin</artifactId> + <configuration> + <createDependencyReducedPom>true</createDependencyReducedPom> + </configuration> + <executions> + <execution> + <id>shade-guava</id> + <phase>package</phase> + <goals> + <goal>shade</goal> + </goals> + <configuration> + <artifactSet> + <includes> + <include>com.google.guava:*</include> + </includes> Review comment: Though, dependencies are not included above, in the shaded jar not all of them are included. Following are dependencies listed by dependency:tree. So lets shade and relocate everything guava needs. So need to check the package in remaining jars as well and relocate them too. ``` [INFO] org.apache.hadoop.thirdparty:hadoop-shaded-guava:jar:1.1.0-SNAPSHOT [INFO] \- com.google.guava:guava:jar:29.0-jre:compile [INFO] +- com.google.guava:failureaccess:jar:1.0.1:compile [INFO] +- com.google.guava:listenablefuture:jar:9999.0-empty-to-avoid-conflict-with-guava:compile [INFO] +- com.google.code.findbugs:jsr305:jar:3.0.2:compile [INFO] +- org.checkerframework:checker-qual:jar:2.11.1:compile [INFO] \- com.google.j2objc:j2objc-annotations:jar:1.3:compile ``` ########## File path: pom.xml ########## @@ -95,6 +95,7 @@ <shaded.prefix>org.apache.hadoop.thirdparty</shaded.prefix> <protobuf.shade.prefix>${shaded.prefix}.protobuf</protobuf.shade.prefix> <protobuf_3_7.version>3.7.1</protobuf_3_7.version> + <guava.version>29.0-jre</guava.version> Review comment: Update the title of PR to reflect version. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-dev-h...@hadoop.apache.org
