I would be fine with a discussion and vote on relaxing some checkstyle restrictions.
Regarding line length, my personal preference is to leave it at 80, but 80 is arbitrary and I would not oppose 100 if that's what people want. Another one that I think should be relaxed is the limit on number of arguments to a method. I understand that a ton of arguments makes a method messy, but I find it irritating when I add an argument to something that is already over the limit and I get penalized for it. The ones I have seen are all constructor methods. -Eric On Thursday, May 13, 2021, 10:10:27 AM CDT, Sean Busbey <sbus...@apple.com.invalid> wrote: Hi folks! I’d like to start cleaning up our nightly tests. As a bit of low hanging fruit I’d like to alter some of our check style rules to match what I think we’ve been doing in the community. How would folks prefer I make sure we have consensus on such changes? As an example, our last nightly run had ~81k check style violations (it’s a big number but it’s not that bad given the size of the repo) and roughly 16% of those were for line lengths in excess of 80 characters but <= 100 characters. If I wanted to change our line length check to be 100 characters rather than the default of 80, would folks rather I have a DISCUSS thread first? Or would they rather a Jira + PR with the discussion of the merits happening there? — busbey --------------------------------------------------------------------- To unsubscribe, e-mail: mapreduce-dev-unsubscr...@hadoop.apache.org For additional commands, e-mail: mapreduce-dev-h...@hadoop.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-dev-h...@hadoop.apache.org
