I'm of a similar opinion to most here. If the backport is clean, I think it's ok to do it with just the +1 on the original patch. However, please please please build the code on the target branch before backporting
Eric On Wed, Jun 2, 2021 at 2:46 PM Ayush Saxena <ayush...@gmail.com> wrote: > For trivial changes, like changes in import or conflicts due to line > number or other trivial stuff, I don’t think that is required. Unless the > general logic isn’t changing, we can go ahead, may be we can do a test run > before merging, to be on the safer side as and when required. :-) > > -Ayush > > > On 02-Jun-2021, at 10:13 AM, Wei-Chiu Chuang <weic...@apache.org> wrote: > > > > I'm curious about the GitHub PR conventions we use today... say I want > to > > backport a commit from trunk to branch-3.3, and there's a small code > > conflict so I push a PR against branch-3.3 using GitHub to go through the > > precommit check. > > > > Do I need explicit approval from another committer to merge the backport > > PR? (As.a committer, I know I can merge at any time) or can I merge when > > the precommit comes back okay? > > --------------------------------------------------------------------- > To unsubscribe, e-mail: hdfs-dev-unsubscr...@hadoop.apache.org > For additional commands, e-mail: hdfs-dev-h...@hadoop.apache.org > >
