[ https://issues.apache.org/jira/browse/HADOOP-17769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ayush Saxena resolved HADOOP-17769. ----------------------------------- Fix Version/s: 3.3.2 3.2.3 2.10.2 3.4.0 Hadoop Flags: Reviewed Resolution: Fixed > Upgrade JUnit to 4.13.2 > ----------------------- > > Key: HADOOP-17769 > URL: https://issues.apache.org/jira/browse/HADOOP-17769 > Project: Hadoop Common > Issue Type: Bug > Affects Versions: 3.3.1, 3.4.0, 2.10.2, 3.2.3 > Reporter: Ahmed Hussein > Assignee: Ahmed Hussein > Priority: Major > Labels: pull-request-available > Fix For: 3.4.0, 2.10.2, 3.2.3, 3.3.2 > > Time Spent: 4.5h > Remaining Estimate: 0h > > JUnit 4.13.1 has a bug that is reported in Junit > [issue-1652|https://github.com/junit-team/junit4/issues/1652] _Timeout > ThreadGroups should not be destroyed_ > After upgrading Junit to 4.13.1 in HADOOP-17602, {{TestBlockRecovery}} > started to fail regularly in branch-3.x and branch-2.10. > While investigating the failure in branch-2.10 HDFS-16072, I found out that > the bug is the main reason {{TestBlockRecovery}} started to fail because the > timeout of the Junit would try to close a ThreadGroup that has been already > closed which throws the {{java.lang.IllegalThreadStateException}}. > The bug has been fixed in Junit-4.13.2 > For branch-3.x, HDFS-15940 did not address the root cause of the problem. > Eventually, Splitting the {{TestBlockRecovery}} hid the bug, but the upgrade > needs to be done so that the problem does not show up in another unit test. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-dev-h...@hadoop.apache.org