You are absolutely correct in pointing out that we should update the setup instructions to include how to install the mysql connector.
With GPL'ed software, the further we can put it off the better, but adding new modules to contain this code also introduces more burden on both the project and the users. Looking through the patch again, it looks like only place references 'com.mysql.*' at all is hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/security/token/SQLConnectionFactory.java and it isn't clear why that import is necessary. Of course if you configure the mysql token store, you'll need the mysql connector at runtime. At LinkedIn, the mysql token store performed 10x better than the zookeeper one. .. Owen On Fri, Jun 9, 2023 at 7:19 AM Wei-Chiu Chuang <weic...@apache.org> wrote: > Thanks Owen, > > Yes I am aware of the optional category X. I was under the impression that > the "optionality" need to be more explicit. For example, by adding > <optional>true</optional> tag. > > https://medium.com/@danismaz.furkan/difference-between-optional-true-optional-and-scope-provided-scope-7404ec24fb59 > > In this case, RBF is used by a small set of Hadoop users, moreover an even > smaller subset of them will choose to use the mysql backend. > > (And there need to be instructions for how to acquire the mysql connector > jar since it's not shipped in the convenience binary) > > On Thu, Jun 8, 2023 at 10:55 PM Owen O'Malley <owen.omal...@gmail.com> > wrote: > > > We are allowed to use category X software in optional components. > > Furthermore, the dependency is marked as provided, so it won't be pulled > > into a transitive closure. > > > > You are right that I should have included a comment about that on the > > original jira. > > > > .. Owen > > > > > > On Fri, Jun 9, 2023 at 1:58 AM Wei-Chiu Chuang > > <weic...@cloudera.com.invalid> > > wrote: > > > > > Hi community, > > > > > > While preparing for 3.3.6 RC, I realized the mysql-connector-java > > > dependency added by HADOOP-18535 > > > <https://issues.apache.org/jira/browse/HADOOP-18535> is GPL licensed. > > > > > > > > > Source: > > > https://github.com/mysql/mysql-connector-j/blob/release/8.0/LICENSE > > > See legal discussion at Apache LEGAL-423 > > > <https://issues.apache.org/jira/browse/LEGAL-423>. > > > > > > I looked at the original jira and github PR and I don't think the > license > > > issue was noticed. > > > > > > Is it possible to get rid of the mysql connector dependency? As far as > I > > > can tell the dependency is very limited. > > > > > > If not, I guess I'll have to revert the commits for now. > > > > > >
