ConfX created HADOOP-18905:
------------------------------
Summary: Negative timeout in ZKFailovercontroller due to overflow
Key: HADOOP-18905
URL: https://issues.apache.org/jira/browse/HADOOP-18905
Project: Hadoop Common
Issue Type: Bug
Affects Versions: 3.3.6
Reporter: ConfX
Graceful fence timeout of FailoverController in ZKFailovercontroller equals to
`ha.failover-controller.graceful-fence.rpc-timeout.ms` * 2. Since users are
unaware of this calculation, it thus has risks of overflowing to a negative
number if users set `ha.failover-controller.graceful-fence.rpc-timeout.ms` to a
large value.
To reproduce:
1. set `ha.failover-controller.graceful-fence.rpc-timeout.ms` to 1092752431
2. run `mvn surefire:test
-Dtest=org.apache.hadoop.ha.TestZKFailoverController#testGracefulFailoverFailBecomingStandby`
This PR provides a fix by checking the timeout after multiplication is at least
0.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org
