Steve Loughran created HADOOP-19330:
---------------------------------------
Summary: S3AInputStream.finalizer to warn if closed with http
connection -then release it
Key: HADOOP-19330
URL: https://issues.apache.org/jira/browse/HADOOP-19330
Project: Hadoop Common
Issue Type: Sub-task
Components: fs/s3
Affects Versions: 3.4.1
Reporter: Steve Loughran
Assignee: Steve Loughran
A recurring problem is that applications forget to close their input streams;
eventually the HTTP connection runs out.
Having the finalizer close streams during GC will ensure that after a GC the
http connections are returned. While this is an improvement on today, it is
insufficient
* only happens during GC, so may not fix problem entirely
* doesn't let developers know things are going wrong.
* doesn't let us differentiate well between stream leak and overloaded FS
proposed enhancements then
* collect stack trace in constructor
* log in finalize at warn including path, thread and stack
* have special log for this, so it can be turned off in production (libraries
telling end users off for developer errors is simply an annoyance)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
