[
https://issues.apache.org/jira/browse/HADOOP-5640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12726838#action_12726838
]
Tom White commented on HADOOP-5640:
-----------------------------------
{quote}
Can you explain more about the ServiceEvent idea? I think this is similar to
one of the ideas discussed above, but I think it's cleaner to use actual
methods with full signatures rather than exposing a single
"handleEvent(ServiceEvent e)" and switching on "e instanceof FooEvent" vs "e
instanceof BarEvent".
{quote}
I agree, I was just suggesting having a ServiceEvent parameter to hang other
contextual information off, to ease API evolution in the future.
{quote}
bq. SingleArgumentRunnable might be named ServicePluginCallback to better
indicate its use.
I disagree - this is a very generic interface that is quite usable for a lot of
different things. Since this code is going in util, we might as well make it
available for other use cases as well rather than proliferating several
interfaces that have the same use.
{quote}
I would argue that code goes into common once it has been demonstrated that it
is needed by more than one other subproject. This is true in this case since
there will be HDFS and MapReduce plugins, so it makes sense for the service
plugin stuff to live in util in common. Whether SingleArgumentRunnable is
better called ServicePluginCallback or not depends on whether the interface
gains further adoption outside service plugins. This is hard to predict so I'm
+0 on calling it SingleArgumentRunnable.
> Allow ServicePlugins to hook callbacks into key service events
> --------------------------------------------------------------
>
> Key: HADOOP-5640
> URL: https://issues.apache.org/jira/browse/HADOOP-5640
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: hadoop-5640.txt, hadoop-5640.txt, HADOOP-5640.v2.txt,
> hadoop-5640.v3.txt
>
>
> HADOOP-5257 added the ability for NameNode and DataNode to start and stop
> ServicePlugin implementations at NN/DN start/stop. However, this is
> insufficient integration for some common use cases.
> We should add some functionality for Plugins to subscribe to events generated
> by the service they're plugging into. Some potential hook points are:
> NameNode:
> - new datanode registered
> - datanode has died
> - exception caught
> - etc?
> DataNode:
> - startup
> - initial registration with NN complete (this is important for HADOOP-4707
> to sync up datanode.dnRegistration.name with the NN-side registration)
> - namenode reconnect
> - some block transfer hooks?
> - exception caught
> I see two potential routes for implementation:
> 1) We make an enum for the types of hookpoints and have a general function in
> the ServicePlugin interface. Something like:
> {code:java}
> enum HookPoint {
> DN_STARTUP,
> DN_RECEIVED_NEW_BLOCK,
> DN_CAUGHT_EXCEPTION,
> ...
> }
> void runHook(HookPoint hp, Object value);
> {code}
> 2) We make classes specific to each "pluggable" as was originally suggested
> in HADDOP-5257. Something like:
> {code:java}
> class DataNodePlugin {
> void datanodeStarted() {}
> void receivedNewBlock(block info, etc) {}
> void caughtException(Exception e) {}
> ...
> }
> {code}
> I personally prefer option (2) since we can ensure plugin API compatibility
> at compile-time, and we avoid an ugly switch statement in a runHook()
> function.
> Interested to hear what people's thoughts are here.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.