[
https://issues.apache.org/jira/browse/HADOOP-6176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12740191#action_12740191
]
Jakob Homan commented on HADOOP-6176:
-------------------------------------
+1 with a readability nit: it may be nice to explicitly state in a comment that
the tests are needed to expose otherwise private methods for testing. May be a
reasonable assumption to make on the reader's part, but clarity is always a
good thing.
> Adding a couple private methods to AccessTokenHandler for testing purposes
> --------------------------------------------------------------------------
>
> Key: HADOOP-6176
> URL: https://issues.apache.org/jira/browse/HADOOP-6176
> Project: Hadoop Common
> Issue Type: Test
> Components: security
> Reporter: Kan Zhang
> Assignee: Kan Zhang
> Attachments: core-03.patch
>
>
> To support some test cases being added as part of HDFS-409, a couple private
> methods need to be added to AccessTokenHandler. One is for setting token
> lifetime and another is checking if a token has expired.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
