[ 
https://issues.apache.org/jira/browse/HADOOP-6188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12742030#action_12742030
 ] 

Jakob Homan commented on HADOOP-6188:
-------------------------------------

+1 on the new patch. I also manually tested that with the new jar TestHDFSTrash 
no longer fails.

 I'm not overly concerned with the non-final parameters as the function is just 
a few lines and the variables aren't being abused.  

Of note is the necessity of checking for null from listStatus.  This is to 
avoid the fact that the listStatus implementation differs between 
Local/ChecksumFileSystem and DistributedFileSystem.  I've opened HDFS-538 to 
address this.

> TestHDFSTrash fails because of TestTrash in common
> --------------------------------------------------
>
>                 Key: HADOOP-6188
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6188
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>            Reporter: Boris Shkolnik
>         Attachments: HADOOP-6188.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to