[ 
https://issues.apache.org/jira/browse/HADOOP-5556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745339#action_12745339
 ] 

Hadoop QA commented on HADOOP-5556:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12417111/HADOOP-5556.patch
  against trunk revision 804918.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 12 new or modified tests.

    -1 patch.  The patch command could not apply the patch.

Console output: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/616/console

This message is automatically generated.

> A few improvements to DataNodeCluster
> -------------------------------------
>
>                 Key: HADOOP-5556
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5556
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: test
>            Reporter: Hairong Kuang
>            Assignee: Hairong Kuang
>             Fix For: 0.21.0
>
>         Attachments: DataNodeCluster.patch, HADOOP-5556.patch
>
>
> DataNodeCluster is a great tool to simulate a large scale DFS cluster using a 
> small set of machines. A few suggestions to improve this tool:
> # DataNodeCluster uses MiniDFSCluster#startDataNode to start multiple 
> instances of DataNode on one machine. MiniDFSCluster sets DataNode's address 
> to be 127.0.0.1. We should allow to set its address to 0.0.0.0 so DataNodes 
> in different machines could communicate.
> # Currently the size of the blocks injected to DataNode and created in 
> CreatedEditsLog is hardcoded as 10. It would be more convenient if this could 
> be configurable. Also we need to make sure that both use the same block size.
> # If the replication factor of blocks is larger than 1, currently a DataNode 
> in DataNodeCluster will be injected blocks multiple times and therefore it 
> sends block reports to NameNode multiple times. Initial block reports contain 
> only a portion of its blocks and therefore may cause unnecessary block 
> replications. It would be cleaner if only one block report with all its 
> blocks is sent. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to