[ 
https://issues.apache.org/jira/browse/HADOOP-6201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jakob Homan updated HADOOP-6201:
--------------------------------

    Attachment: HADOOP-6201.patch

Made change as discussed in Jira.  Surveyed implementaions of FileSystem and 
found that about half of them were throwing FileNotFound (Har, FTP), the other 
half were returning null (S3, Local, KFS), so it's good we caught this. There 
were lots of places null wasn't being checked for and could have eventually 
resulted in an NPE.

As far as I know, this is the first patch to cut across all three projects.  
Uploading patches for HDFS and MR, but they can't be tested without being in a 
specific order.  I have manually tested everything and it all works.  
Test-patch won't be helpful here.  

In terms of the commiter applying the patches and generating jars:
1) Apply HADOOP-6201 and generated new common jar (C)
2) Apply HDFS-538 and pull in C.  Won't work because MapReduce jar needs 
updated. Generate new HDFS jar (H)
3) Apply MAPREDUCE-895 and pull in C and H. Generate new MapReduce jar (M)
4) Pull M into HDFS.  
5) Everything should work, but this speaks to the difficulty of generating 
patches across all three projects.

> FileSystem::ListStatus should throw FileNotFoundException
> ---------------------------------------------------------
>
>                 Key: HADOOP-6201
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6201
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs
>            Reporter: Jakob Homan
>            Assignee: Jakob Homan
>         Attachments: HADOOP-6201.patch
>
>
> As discussed in HDFS-538, it would be better for FileSystem and its 
> implementations to throw FileNotFoundException when the file is not found, 
> rather than returning null.  This will bring it in line with getFileStatus 
> and, I expect, default user expectations.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to