[ 
https://issues.apache.org/jira/browse/HADOOP-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tom White updated HADOOP-5732:
------------------------------

    Attachment: HADOOP-5732.patch

I've updated the patch so that applies to trunk. As it stands the unit test 
isn't self-contained. Can this be done by having an embedded SFTP server like 
TestFTPFileSystem does? (Although see 
https://issues.apache.org/jira/browse/HDFS-441.)

If this is not possible then the test should be renamed SFTPFileSystemTest so 
it isn't run as a part of the automated test suite.

Ideally, the FileSystem interface contract should also be tested by subclassing 
FileSystemContractBaseTest and overriding the setUp() method to set the 
filesystem under test to be SFTPFileSystem. See TestHDFSFileSystemContract in 
the HDFS project for an example of how to do this. This test checks lots of 
edge cases and will help flush out common issues with writing FileSystem 
implementations.

> should I add a modification in hadoop-default.xml in order to add 
> fs.impl.sftp value?

Yes please.



> SFTP FileSystem
> ---------------
>
>                 Key: HADOOP-5732
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5732
>             Project: Hadoop Common
>          Issue Type: New Feature
>          Components: fs
>    Affects Versions: 0.20.0
>         Environment: Any environment
>            Reporter: Íñigo Goiri
>            Assignee: Íñigo Goiri
>            Priority: Minor
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-5732.patch, HADOOP-5732.patch, HADOOP-5732.patch, 
> HADOOP-5732.patch, HADOOP-5732.patch, ivy-for-hadoop-7532.patch, 
> ivy-for-hadoop-7532.patch
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> I have implemented a FileSystem that supports SFTP. It uses JSch 
> (http://www.jcraft.com/jsch/) in order to manage SFTP.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to