[ 
https://issues.apache.org/jira/browse/HADOOP-6420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12787917#action_12787917
 ] 

Tom White commented on HADOOP-6420:
-----------------------------------

A couple of comments on the patch:
* In the documentation for setMap() say that "name" should not have a trailing 
period.
* Deprecation needs to be handled for getMap(). Also variable substitution. 
This could be fixed by calling Configuration's get(), rather than the 
underlying Properties. (You could use the Properties object to get the keys 
still.) It would be good to add unit tests for these cases.

> String-to-String Maps should be embeddable in Configuration
> -----------------------------------------------------------
>
>                 Key: HADOOP-6420
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6420
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>            Reporter: Aaron Kimball
>            Assignee: Aaron Kimball
>         Attachments: HADOOP-6420.patch
>
>
> Per MAPREDUCE-1126, we need to be able to take a map of (key, value) pairs 
> and embed that inside a Configuration object.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to