[ 
https://issues.apache.org/jira/browse/HADOOP-6427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12789123#action_12789123
 ] 

Eli Collins commented on HADOOP-6427:
-------------------------------------

bq. Can you further describe the use-case for this method? When will it be 
called?

When creating a symlink in FileContext we both want to give the NN a fully 
qualified path, and make sure getLinkTarget in the NN returns a fully qualified 
path. If the NN returned an absolute path FileContext would interpret it to be 
relative to the FileContext's slash not the NN's.

bq. Perhaps we should have a filesystem-specific method that indicates whether 
a path is fully-qualified?

I'm assuming the isQualified implementation for the "file" scheme would then 
live in LocalFs, ie is just special cased in a different place. Delegating to a 
file system seems a little weird since a Path can construct a fully qualified 
path without a file system. However from RFC 2396 it looks like the authority 
is part of the scheme specific part of the URI and therefore should be 
delegated to the scheme, which in our case is represented by an 
AbstractFileSystem. So yea it does seem more logical to delegate this method to 
the file system, I'll do that.

> Add Path isQualified
> --------------------
>
>                 Key: HADOOP-6427
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6427
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>         Attachments: hadoop-6427-1.patch
>
>
> The Path class has a method to make a path qualified but not to query if the 
> path is qualified. This is needed for HADOOP-64221. In addition this patch 
> adds tests to TestPath that cover the file scheme. Note that "fully 
> qualified" applies to domain names not URIs so this function and it tests 
> also serve to define what we mean by a fully qualified path.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to