[ 
https://issues.apache.org/jira/browse/HADOOP-5912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12792778#action_12792778
 ] 

Konstantin Boudnik commented on HADOOP-5912:
--------------------------------------------

Patch looks almost good. One nit:
{noformat}
 
+  
   /**
-   * Launch a task JVM that will run as the owner of the job.
+   * <p>Launch a task JVM that will run as the owner of the job.</p>
{noformat}

Generally you should avoid black line modifications. Please fix it and submit 
the patch for the verification.

> Document exit codes and their meanings used by linux task controller
> --------------------------------------------------------------------
>
>                 Key: HADOOP-5912
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5912
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: documentation
>            Reporter: Sreekanth Ramakrishnan
>            Assignee: Anatoli Fomenko
>            Priority: Blocker
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-5912.1.patch
>
>
> Currently, linux task controller binary uses a set of exit code, which is not 
> documented. These should be documented.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to