[ 
https://issues.apache.org/jira/browse/HADOOP-6471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794764#action_12794764
 ] 

Hadoop QA commented on HADOOP-6471:
-----------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12429003/HADOOP-6471.patch
  against trunk revision 893666.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 12 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/242/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/242/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/242/artifact/trunk/build/test/checkstyle-errors.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/242/console

This message is automatically generated.

> StringBuilder -> StringBuilder unnecessary references 
> ------------------------------------------------------
>
>                 Key: HADOOP-6471
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6471
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Kay Kay
>             Fix For: 0.20.2
>
>         Attachments: HADOOP-6471.patch
>
>
> Across hadoop-common codebase,  a good number of StringBuffer-s being used 
> are actually candidates for StringBuilders , since the reference does not 
> escape the scope of the method and no concurrency is needed. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to