[
https://issues.apache.org/jira/browse/HADOOP-6453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12795100#action_12795100
]
Steve Loughran commented on HADOOP-6453:
----------------------------------------
I agree, handling broken env variables is a losing battle. They can break it in
so many ways that it's impossible to fix; the classic enemy is the quotation
marks halfway through PATH; this screws up the quote logic and your scripts
don't stand a chance, not in anything vaguely cross platform. Perl or Python
entry scripts, that's a different story.
For bash, the cygpath patch should be enough.
I've been thinking about how to test this. TestCLI can be used to run stuff on
the command line, all we need is a hadoop diagnostics command whose output
includes all the env variables. If JAVA_LIBRARY_PATH is then set to values with
and without a space in in different test cases (that will be the tricky bit;
may need some extensions to the cli execution), the test could look for the
value in the output. I will file that as a separate feature.
> Hadoop wrapper script shouldn't ignore an existing JAVA_LIBRARY_PATH
> --------------------------------------------------------------------
>
> Key: HADOOP-6453
> URL: https://issues.apache.org/jira/browse/HADOOP-6453
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.20.2, 0.21.0, 0.22.0
> Reporter: Chad Metcalf
> Assignee: Chad Metcalf
> Priority: Minor
> Fix For: 0.20.2, 0.21.0, 0.22.0
>
> Attachments: HADOOP-6453-0.20.patch, HADOOP-6453-0.20v2.patch,
> HADOOP-6453-trunkv2.patch, HADOOP-6453.trunk.patch
>
>
> Currently the hadoop wrapper script assumes its the only place that uses
> JAVA_LIBRARY_PATH and initializes it to a blank line.
> JAVA_LIBRARY_PATH=''
> This prevents anyone from setting this outside of the hadoop wrapper (say
> hadoop-config.sh) for their own native libraries.
> The fix is pretty simple. Don't initialize it to '' and append the native
> libs like normal.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
