[ 
https://issues.apache.org/jira/browse/HADOOP-6420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12797397#action_12797397
 ] 

Chris Douglas commented on HADOOP-6420:
---------------------------------------

bq. You could conceivably hold an explicit reference to the Configuration 
object, but given that the implicit reference is the whole point of a 
non-static inner class, I don't see what using a static class buys us.

I intended (5) to depend on (2); since the deprecation semantics push for an 
inner class, the point is moot. The static/inner class is just a matter of 
taste; if the inner class didn't require access to private members, limiting 
its visibility to public methods keeps the APIs clean.

Given its semantics, {{addMap}} (implying _A_) may be more apt than {{setMap}} 
(implying _B_), but it's debatable and the documentation makes its semantics 
clear.

+1

> String-to-String Maps should be embeddable in Configuration
> -----------------------------------------------------------
>
>                 Key: HADOOP-6420
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6420
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>            Reporter: Aaron Kimball
>            Assignee: Aaron Kimball
>         Attachments: HADOOP-6420.10.patch, HADOOP-6420.2.patch, 
> HADOOP-6420.3.patch, HADOOP-6420.4.patch, HADOOP-6420.5.patch, 
> HADOOP-6420.6.patch, HADOOP-6420.7.patch, HADOOP-6420.8.patch, 
> HADOOP-6420.9.patch, HADOOP-6420.patch
>
>
> Per MAPREDUCE-1126, we need to be able to take a map of (key, value) pairs 
> and embed that inside a Configuration object.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to