[ 
https://issues.apache.org/jira/browse/HADOOP-6421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832550#action_12832550
 ] 

Sanjay Radia commented on HADOOP-6421:
--------------------------------------

Comments on the tests for patch 37.
Thanks for addressing my comments.


* testLocalFSFileContextSymlink#testGetLinkStatusPartQualTarget  - you create a 
link "hdfs://host:1000/dir/file". This link should fail on local fs. (see
my previous comment).

* Move the setPermissions and setTimes tests from HDFS to Common (you can do 
this in a separate jira if you prefer, though you might find it
easier to do in this patch.)

* File a jira to use the test library (your issue with the test library and 
eclipse noted). We need to fix the test library to address the eclipse issue 
and 
then change the symlink test. The other fileContext tests use the test library.

> Symbolic links
> --------------
>
>                 Key: HADOOP-6421
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6421
>             Project: Hadoop Common
>          Issue Type: New Feature
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>         Attachments: symlink-25-common.patch, symlink-26-common.patch, 
> symlink-26-common.patch, symlink24-common.patch, symlink27-common.patch, 
> symlink28-common.patch, symlink29-common.patch, symlink29-common.patch, 
> symlink29-common.patch, symlink30-common.patch, symlink31-common.patch, 
> symlink32-common.patch, symlink33-common.patch, symlink34-common.patch, 
> symlink35-common.patch, symlink36-common.patch, symlink37-common.patch
>
>
> Here's a jira for the common parts of HDFS-245, mostly changes to FileContext 
> and AbstractFileSystem.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to