[
https://issues.apache.org/jira/browse/HADOOP-6579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12837952#action_12837952
]
Philip Zeyliger commented on HADOOP-6579:
-----------------------------------------
Hi Owen,
Trying to keep up with some of the security jiras. You're producing a lot of
code, thereby making it tricky :)
I think, in general, it's not that useful to write arbitrary writables to
base64-encoded strings. Most browsers limit how long URL strings can be, so
you've got to be pretty careful about what you're up to. Would you consider
instead making this more specific, by moving this code into
Token.getAsUrlSafeString() and (static) Token.fromUrlSafeString()? Or,
equivalently, leave the code here, but in redirectToRandomDataNode() (patch in
HDFS-991), use a method on the Token instead of WritableUtils. (This has the
additional property that one could serialize tokens however; they just have to
have a URL-safe string serialization.)
Looked at the code and tests. Those look clear and good.
-- Philip
> A utility for reading and writing tokens into a URL safe string.
> ----------------------------------------------------------------
>
> Key: HADOOP-6579
> URL: https://issues.apache.org/jira/browse/HADOOP-6579
> Project: Hadoop Common
> Issue Type: Improvement
> Components: security
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 0.22.0
>
> Attachments: c-6579-hdfs.patch, c-6579-mr.patch, c-6579.patch,
> c-6579.patch
>
>
> We need to include HDFS delegation tokens in the URLs while browsing the file
> system. Therefore, we need a url-safe way to encode and decode them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
