[
https://issues.apache.org/jira/browse/HADOOP-6382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12843859#action_12843859
]
Chris Douglas commented on HADOOP-6382:
---------------------------------------
Very minor, largely cosmetic nits:
* This should be removed:
{noformat}
+ <echo> phassphrase : ${gpg.passphrase} </echo>
{noformat}
* The pom template properties have odd names:
{noformat}
+ <property name="hadoop-core-pom-template.xml"
+ location="${ivy.dir}/hadoop-core-pom-template.xml"/>
{noformat}
({{${filename.xml}}} looks like an error). Leaving off the .xml suffix and
following the convention of {{.}} rather than {{\-}} as a separator in property
names would help readers parse these sections.
* Existing templates are named {{foobar.xml.template}} rather than
{{foobar-template.xml}}. Is there a reason for the different naming scheme?
* The {{hadoop.jar}} property is no longer used and can be removed or should
use the new name for the core jar:
{noformat}
- <property name="hadoop.jar"
location="${build.dir}/hadoop-${hadoop.version}-core.jar" />
+ <property name="hadoop.jar"
+ location="${build.dir}/hadoop-${hadoop.version}-core.jar"/>
{noformat}
* Deleting all {{.asc}} files in the tree rather than using a common list for
signing/deleting may be too aggressive. However, relaxing this can be an
enhancement and doesn't block commit
According to Lee, that the pom templates are static- and don't update versions
with ivy, used for versioning dependencies elsewhere- is by design for this
pass.
I agree that adding the javadoc and sources jars can be pushed to a separate
issue (since this will also need to happen on trunk). The changes complying
with maven naming conventions require that this be marked as an incompatible
change (the build now generates {{hadoop\-<name>\-<version>.jar}} vs previous
({{hadoop\-<version>\-<name>.jar}}), so this needs a release note calling that
out.
Other than these, the patch looks good and its effect in staging has been
confirmed by members of the Mahout team (thanks Benson and Sean), and it worked
for the 0.20.2 release. Thanks, Giri; this is excellent.
> publish hadoop jars to apache mvn repo.
> ---------------------------------------
>
> Key: HADOOP-6382
> URL: https://issues.apache.org/jira/browse/HADOOP-6382
> Project: Hadoop Common
> Issue Type: New Feature
> Components: build
> Affects Versions: 0.20.0
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
> Attachments: HADOOP-6382-findbugs.patch, HADOOP-6382-findbugs.patch,
> hadoop-6382-v1.patch, hadoop-6382-v2.patch, hadoop-6382-v3.patch,
> hadoop-6382-v4.patch, hadoop-6382.patch, HADOOP-6382.script.patch
>
>
> use maven ant task to publish hadoop 20 jars to the apache maven repo
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
