[ https://issues.apache.org/jira/browse/HADOOP-6194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12861609#action_12861609 ]
Hadoop QA commented on HADOOP-6194: ----------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12443007/HADOOP-6194.patch against trunk revision 938590. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The applied patch generated 1026 javac compiler warnings (more than the trunk's current 1024 warnings). +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/56/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/56/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/56/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/56/console This message is automatically generated. > Add service base class and tests to hadoop-common/util > ------------------------------------------------------ > > Key: HADOOP-6194 > URL: https://issues.apache.org/jira/browse/HADOOP-6194 > Project: Hadoop Common > Issue Type: New Feature > Components: util > Affects Versions: 0.21.0 > Reporter: Steve Loughran > Assignee: Steve Loughran > Fix For: 0.22.0 > > Attachments: HADOOP-6194-1.patch, HADOOP-6194.patch, HADOOP-6194.patch > > > For a service base class, we need to add to common > # The Service class > # A mock Service class (it's not in test, its in src/, because it helps in > functional tests downstream) > # Unit tests > This is the issue to cover this work -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.