[
https://issues.apache.org/jira/browse/HADOOP-6585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12864432#action_12864432
]
Hairong Kuang commented on HADOOP-6585:
---------------------------------------
Wow, Eli, you made a lot of tedious/subtle changes.. Good work!
I agree that we should not change the definition of the deprecated method
isDir. Here are a couple of initial comments. I might post more when I get more
time to review carefully.
FileSystem.java:
1. should change the message of the exception ParentNotDirectoryException;
2. should update the comment in getContentSummary: // f is a file --> // f is a
file or symlink
RawLocalFileSystem.java:
should we change the check getFileStatus(f).isDir() to be
!getFileStatus(f).isFile()?
> Add FileStatus#isDirectory and isFile
> -------------------------------------
>
> Key: HADOOP-6585
> URL: https://issues.apache.org/jira/browse/HADOOP-6585
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Affects Versions: 0.21.0, 0.22.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Blocker
> Fix For: 0.21.0, 0.22.0
>
> Attachments: hadoop-6585-1.patch, hadoop-6585-2.patch,
> hadoop-6585-3.patch
>
>
> Per Sanjay's suggestion in HADOOP-6421 let's deprecate FileStatus#isDir() and
> add isDirectory() and isFile() to compliment isSymlink. Currently clients
> assume !isDir() implies a file, which is no longer true with symlinks. I'll
> file a separate jira to change the various uses of !isDir() to be isFile() or
> isFile() or isSymlink() as appropriate.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
