[ 
https://issues.apache.org/jira/browse/HADOOP-6668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tom White updated HADOOP-6668:
------------------------------

    Attachment: HADOOP-6668.patch

> Please mark Path#makeQualified(URI defaultUri, Path workingDir ) as limited 
> private

Done.

> > PositionedReadable, Seekable and Syncable: I think these are user-facing, 
> > hence Public.
> Unfortunately these interfaces are implemented as user facing. But they are 
> indeed for the implementation of each file system's I/O streams. I prefer not 
> to make them public. 

FSDataInputStream implements PositionedReadable and Seekable, and users can be 
expected to call the public methods on FSDataInputStream that are defined in 
these interfaces. So it seems reasonable to make them public, doesn't it? 
There's a similar argument for FSDataOutputStream and Syncable.

> Apply audience and stability annotations to classes in common
> -------------------------------------------------------------
>
>                 Key: HADOOP-6668
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6668
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: documentation
>            Reporter: Tom White
>            Assignee: Tom White
>            Priority: Blocker
>             Fix For: 0.21.0
>
>         Attachments: common.interface-tw-annotated.txt, HADOOP-6668.patch, 
> HADOOP-6668.patch, HADOOP-6668.patch, HADOOP-6668.patch, HADOOP-6668.patch, 
> HADOOP-6668.patch, HADOOP-6668.patch, HADOOP-6668.patch
>
>
> Mark private implementation classes with the InterfaceAudience.Private or 
> InterfaceAudience.LimitedPrivate annotation to exclude them from user Javadoc 
> and JDiff.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to