[
https://issues.apache.org/jira/browse/HADOOP-11505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15047171#comment-15047171
]
Chris Nauroth commented on HADOOP-11505:
----------------------------------------
The license warning is unrelated, introduced by YARN-4248. I just commented
there asking for a fix.
[~alanburlison], thank you for the review.
bq. I don't get a vote...
Actually, we welcome votes from contributors. We just ask that you call it out
as "+1 (non-binding)". Although we can't commit code based on a non-binding
+1, it's still valuable to know that a contributor has reviewed and accepted
the patch. Your feedback on the native code has been very valuable, so I'd
welcome more of your code reviews.
Since I've touched the patch, I also can't commit based on my own +1. Could
one of the earlier reviewers take another look? The only new changes are in
pom.xml and native.vcxproj, so it won't take much time.
> Various native parts use bswap incorrectly and unportably
> ---------------------------------------------------------
>
> Key: HADOOP-11505
> URL: https://issues.apache.org/jira/browse/HADOOP-11505
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 3.0.0
> Reporter: Colin Patrick McCabe
> Assignee: Alan Burlison
> Fix For: 3.0.0
>
> Attachments: HADOOP-11505.001.patch, HADOOP-11505.003.patch,
> HADOOP-11505.004.patch, HADOOP-11505.005.patch, HADOOP-11505.006.patch,
> HADOOP-11505.007.patch
>
>
> hadoop-mapreduce-client-nativetask fails to use x86 optimizations in some
> cases. Also, on some alternate, non-x86, non-ARM architectures the generated
> code is incorrect. Thanks to Steve Loughran and Edward Nevill for finding
> this.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
