[ https://issues.apache.org/jira/browse/HADOOP-12563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15053664#comment-15053664 ]
Daryn Sharp commented on HADOOP-12563: -------------------------------------- Skimmed the patch because it looks interesting! Please don't use getServiceName and getDelegationToken as your interface. It won't work for multi-token services. There's a reason why the filesystem javadoc refers to using addDelegationTokens. A compound filesystem like ViewFs requires obtaining multiple tokens. Fetching a RM token typically involves also implicitly acquiring a JHS or AHS token. You also cannot assume to know the alias that will be used by a provider which is actually impossible when n-many tokens may be returned. It would be great if you had something like a -fs option so every custom fs doesn't need to register its scheme when path.getFileSystem(conf).addDelegationTokens(....) would handle all scenarios. > Updated utility to create/modify token files > -------------------------------------------- > > Key: HADOOP-12563 > URL: https://issues.apache.org/jira/browse/HADOOP-12563 > Project: Hadoop Common > Issue Type: New Feature > Affects Versions: 3.0.0 > Reporter: Allen Wittenauer > Assignee: Matthew Paduano > Attachments: HADOOP-12563.01.patch, HADOOP-12563.02.patch, > HADOOP-12563.03.patch, HADOOP-12563.04.patch, HADOOP-12563.05.patch, > example_dtutil_commands_and_output.txt, generalized_token_case.pdf > > > hdfs fetchdt is missing some critical features and is geared almost > exclusively towards HDFS operations. Additionally, the token files that are > created use Java serializations which are hard/impossible to deal with in > other languages. It should be replaced with a better utility in common that > can read/write protobuf-based token files, has enough flexibility to be used > with other services, and offers key functionality such as append and rename. > The old version file format should still be supported for backward > compatibility, but will be effectively deprecated. > A follow-on JIRA will deprecrate fetchdt. -- This message was sent by Atlassian JIRA (v6.3.4#6332)