[
https://issues.apache.org/jira/browse/HADOOP-12421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15053891#comment-15053891
]
Mingliang Liu commented on HADOOP-12421:
----------------------------------------
Thanks for working on this. One nit:
{code}
+ long range = (long) (0.075 * retVal);
+
+ // Only add jitter if there is some to add.
+ if (retVal > 0 && range > 0) {
{code}
Can the _if_ condition be simplified as {{range > 0}}?
> Add jitter to RetryInvocationHandler
> ------------------------------------
>
> Key: HADOOP-12421
> URL: https://issues.apache.org/jira/browse/HADOOP-12421
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 2.8.0
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Attachments: HADOOP-12421-v1.patch, HADOOP-12421-v2.patch,
> HADOOP-12421-v3.patch, HADOOP-12421-v4.patch
>
>
> Calls to NN can become synchronized across a cluster during NN failover. This
> leads to a spike in requests until things recover. Making an already tricky
> time worse.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
