[
https://issues.apache.org/jira/browse/HADOOP-11828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15066468#comment-15066468
]
Kai Zheng commented on HADOOP-11828:
------------------------------------
The code looks pretty nice and much clean now. Besides the Jenkins reported
issues you need to look at and clear, some comments:
* In {{AbstractHHErasureCodingStep}}, {{getSubPacketSize}} may be protected
instead of public
* In raw erasure coder level, you can set the {{ALLOW_CHANGE_INPUTS}} coder
option to ensure the input buffers are not changed during encoding/decoding.
Thus in HH coder level, you don't need to clone the input buffers thus avoids
data copy.
* In {{TestErasureCoderBase}}, note HH specific logic was added. Please don't,
because it's for all codec/coders. you can add a test base class for HH like
{{TestHHErasureCoderBase}} that extends {{TestErasureCoderBase}} instead.
> Implement the Hitchhiker erasure coding algorithm
> -------------------------------------------------
>
> Key: HADOOP-11828
> URL: https://issues.apache.org/jira/browse/HADOOP-11828
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Zhe Zhang
> Assignee: jack liuquan
> Attachments: 7715-hitchhikerXOR-v2-testcode.patch,
> 7715-hitchhikerXOR-v2.patch, HADOOP-11828-hitchhikerXOR-V3.patch,
> HADOOP-11828-hitchhikerXOR-V4.patch, HADOOP-11828-hitchhikerXOR-V5.patch,
> HDFS-7715-hhxor-decoder.patch, HDFS-7715-hhxor-encoder.patch
>
>
> [Hitchhiker |
> http://www.eecs.berkeley.edu/~nihar/publications/Hitchhiker_SIGCOMM14.pdf] is
> a new erasure coding algorithm developed as a research project at UC
> Berkeley. It has been shown to reduce network traffic and disk I/O by 25%-45%
> during data reconstruction. This JIRA aims to introduce Hitchhiker to the
> HDFS-EC framework, as one of the pluggable codec algorithms.
> The existing implementation is based on HDFS-RAID.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
