[
https://issues.apache.org/jira/browse/HADOOP-6837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicholas Carlini updated HADOOP-6837:
-------------------------------------
Attachment: HADOOP-6837-lzma-4-20100811.patch
Fixed two FindBugs warnings. Made one variable static and removed another.
Also I fixed build.xml (I think, it works correctly when doing 'ant package' on
src/contrib, and it didn't work on the previous patch) to not crash when ant
package is run. Had to override all of the build-contrib targets with empty
ones. Otherwise it'd go looking for directories which didn't exist (because I
don't need them to exist).
I also changed build-contrib.xml (which is included by the other build.xml's)
to have a compile-before target in it so there won't be any errors (even if I
did set failonerror to false). Safer that way.
FindBugs fails because of four errors in the original SevenZip code. I could
change those to static to make FindBugs happy but that would make more work to
apply a patch to the java code, so unless there's a particularly good reason to
do so I won't.
SIC Should SevenZip.Compression.LZMA.Decoder$LenDecoder be a _static_ inner
class?
SIC Should SevenZip.Compression.LZMA.Decoder$LiteralDecoder be a _static_ inner
class?
SIC Should SevenZip.Compression.LZMA.Encoder$LiteralEncoder be a _static_ inner
class?
SIC Should SevenZip.Compression.LZMA.Encoder$Optimal be a _static_ inner class?
And JavaDoc find an error:
[javadoc] javadoc: error - Illegal package name: ""
However, I can not reproduce this on my local machine. Let's see if it happens
with Hudson.
> Support for LZMA compression
> ----------------------------
>
> Key: HADOOP-6837
> URL: https://issues.apache.org/jira/browse/HADOOP-6837
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
> Reporter: Nicholas Carlini
> Assignee: Nicholas Carlini
> Attachments: HADOOP-6837-lzma-1-20100722.non-trivial.pseudo-patch,
> HADOOP-6837-lzma-1-20100722.patch, HADOOP-6837-lzma-2-20100806.patch,
> HADOOP-6837-lzma-3-20100809.patch, HADOOP-6837-lzma-4-20100811.patch,
> HADOOP-6837-lzma-c-20100719.patch, HADOOP-6837-lzma-java-20100623.patch
>
>
> Add support for LZMA (http://www.7-zip.org/sdk.html) compression, which
> generally achieves higher compression ratios than both gzip and bzip2.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
