[ https://issues.apache.org/jira/browse/HADOOP-12469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15119917#comment-15119917 ]
Gera Shegalov commented on HADOOP-12469: ---------------------------------------- Hi [~liuml07], can you move doTestIgnoreFailures back underneath testDirToFile so it's easier to see what you changed? > distcp should not ignore the ignoreFailures option > -------------------------------------------------- > > Key: HADOOP-12469 > URL: https://issues.apache.org/jira/browse/HADOOP-12469 > Project: Hadoop Common > Issue Type: Bug > Components: tools/distcp > Affects Versions: 2.7.1 > Reporter: Gera Shegalov > Assignee: Mingliang Liu > Priority: Critical > Attachments: HADOOP-12469.000.patch, HADOOP-12469.001.patch, > HADOOP-12469.002.patch, HADOOP-12469.003.patch > > > {{RetriableFileCopyCommand.CopyReadException}} is double-wrapped via > # via {{RetriableCommand::execute}} > # via {{CopyMapper#copyFileWithRetry}} > before {{CopyMapper::handleFailure}} tests > {code} > if (ignoreFailures && exception.getCause() instanceof > RetriableFileCopyCommand.CopyReadException > {code} > which is always false. > Orthogonally, ignoring failures should be mutually exclusive with the atomic > option otherwise an incomplete dir is eligible for commit defeating the > purpose. > -- This message was sent by Atlassian JIRA (v6.3.4#6332)