[ https://issues.apache.org/jira/browse/HADOOP-12702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15120115#comment-15120115 ]
Karthik Kambatla commented on HADOOP-12702: ------------------------------------------- Looks mostly good. Few minor comments: # Should close() call flush()? # rollLogDirIfNeeded: The comments in the method are wrongly indented. And, the exception message at the end should be fixed up to say "Failed to *create* new log file". > Add an HDFS metrics sink > ------------------------ > > Key: HADOOP-12702 > URL: https://issues.apache.org/jira/browse/HADOOP-12702 > Project: Hadoop Common > Issue Type: Improvement > Components: metrics > Affects Versions: 2.7.1 > Reporter: Daniel Templeton > Assignee: Daniel Templeton > Attachments: HADOOP-12702.001.patch, HADOOP-12702.002.patch, > HADOOP-12702.003.patch, HADOOP-12702.004.patch > > > We need a metrics2 sink that can write metrics to HDFS. The sink should > accept as configuration a "directory prefix" and do the following in > {{putMetrics()}} > * Get yyyyMMddHH from current timestamp. > * If HDFS dir "dir prefix" + yyyyMMddHH doesn't exist, create it. Close any > currently open file and create a new file called <hostname>.log in the new > directory. > * Write metrics to the current log file. > * If a write fails, it should be fatal to the process running the sink. -- This message was sent by Atlassian JIRA (v6.3.4#6332)