[
https://issues.apache.org/jira/browse/HADOOP-12469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mingliang Liu updated HADOOP-12469:
-----------------------------------
Attachment: HADOOP-12469.004.patch
Thanks [~jira.shegalov] for your review and comments. The v4 patch moves the
{{doTestIgnoreFailures()}} method back to its old position.
The patch mainly changes helper method {{doTestIgnoreFailures}} by creating a
file and making it unusable by setting 000 permission. The unit test
{{testIgnoreFailures}} can not pass in trunk code without this patch, as it
should wrap the CopyReadException only once.
> distcp should not ignore the ignoreFailures option
> --------------------------------------------------
>
> Key: HADOOP-12469
> URL: https://issues.apache.org/jira/browse/HADOOP-12469
> Project: Hadoop Common
> Issue Type: Bug
> Components: tools/distcp
> Affects Versions: 2.7.1
> Reporter: Gera Shegalov
> Assignee: Mingliang Liu
> Priority: Critical
> Attachments: HADOOP-12469.000.patch, HADOOP-12469.001.patch,
> HADOOP-12469.002.patch, HADOOP-12469.003.patch, HADOOP-12469.004.patch
>
>
> {{RetriableFileCopyCommand.CopyReadException}} is double-wrapped via
> # via {{RetriableCommand::execute}}
> # via {{CopyMapper#copyFileWithRetry}}
> before {{CopyMapper::handleFailure}} tests
> {code}
> if (ignoreFailures && exception.getCause() instanceof
> RetriableFileCopyCommand.CopyReadException
> {code}
> which is always false.
> Orthogonally, ignoring failures should be mutually exclusive with the atomic
> option otherwise an incomplete dir is eligible for commit defeating the
> purpose.
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
