[ https://issues.apache.org/jira/browse/HADOOP-12488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15195810#comment-15195810 ]
Hadoop QA commented on HADOOP-12488: ------------------------------------ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 9s {color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s {color} | {color:green} The patch appears to include 1 new or modified test files. {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 15s {color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m 36s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 5m 37s {color} | {color:green} trunk passed with JDK v1.8.0_74 {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 6m 32s {color} | {color:green} trunk passed with JDK v1.7.0_95 {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 5s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 44s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 28s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 27s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 58s {color} | {color:green} trunk passed with JDK v1.8.0_74 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 50s {color} | {color:green} trunk passed with JDK v1.7.0_95 {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 14s {color} | {color:blue} Maven dependency ordering for patch {color} | | {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 25s {color} | {color:red} hadoop-hdfs in the patch failed. {color} | | {color:red}-1{color} | {color:red} compile {color} | {color:red} 1m 27s {color} | {color:red} root in the patch failed with JDK v1.8.0_74. {color} | | {color:red}-1{color} | {color:red} cc {color} | {color:red} 1m 27s {color} | {color:red} root in the patch failed with JDK v1.8.0_74. {color} | | {color:red}-1{color} | {color:red} javac {color} | {color:red} 1m 27s {color} | {color:red} root in the patch failed with JDK v1.8.0_74. {color} | | {color:red}-1{color} | {color:red} compile {color} | {color:red} 1m 37s {color} | {color:red} root in the patch failed with JDK v1.7.0_95. {color} | | {color:red}-1{color} | {color:red} cc {color} | {color:red} 1m 37s {color} | {color:red} root in the patch failed with JDK v1.7.0_95. {color} | | {color:red}-1{color} | {color:red} javac {color} | {color:red} 1m 37s {color} | {color:red} root in the patch failed with JDK v1.7.0_95. {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m 3s {color} | {color:red} root: patch generated 3 new + 84 unchanged - 4 fixed = 87 total (was 88) {color} | | {color:red}-1{color} | {color:red} mvnsite {color} | {color:red} 0m 28s {color} | {color:red} hadoop-hdfs in the patch failed. {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 24s {color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s {color} | {color:red} The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 18s {color} | {color:red} hadoop-hdfs in the patch failed. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 54s {color} | {color:green} the patch passed with JDK v1.8.0_74 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 41s {color} | {color:green} the patch passed with JDK v1.7.0_95 {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 6m 51s {color} | {color:green} hadoop-common in the patch passed with JDK v1.8.0_74. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 23s {color} | {color:red} hadoop-hdfs in the patch failed with JDK v1.8.0_74. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 6m 43s {color} | {color:red} hadoop-common in the patch failed with JDK v1.7.0_95. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 26s {color} | {color:red} hadoop-hdfs in the patch failed with JDK v1.7.0_95. {color} | | {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m 19s {color} | {color:red} Patch generated 1 ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 60m 27s {color} | {color:black} {color} | \\ \\ || Reason || Tests || | JDK v1.7.0_95 Failed junit tests | hadoop.security.ssl.TestReloadingX509TrustManager | \\ \\ || Subsystem || Report/Notes || | Docker | Image:yetus/hadoop:0ca8df7 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12793572/HADOOP-12488.002.patch | | JIRA Issue | HADOOP-12488 | | Optional Tests | asflicense compile cc mvnsite javac unit javadoc mvninstall findbugs checkstyle | | uname | Linux c93759e9d50c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh | | git revision | trunk / d457401 | | Default Java | 1.7.0_95 | | Multi-JDK versions | /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 | | findbugs | v3.0.0 | | mvninstall | https://builds.apache.org/job/PreCommit-HADOOP-Build/8855/artifact/patchprocess/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt | | compile | https://builds.apache.org/job/PreCommit-HADOOP-Build/8855/artifact/patchprocess/patch-compile-root-jdk1.8.0_74.txt | | cc | https://builds.apache.org/job/PreCommit-HADOOP-Build/8855/artifact/patchprocess/patch-compile-root-jdk1.8.0_74.txt | | javac | https://builds.apache.org/job/PreCommit-HADOOP-Build/8855/artifact/patchprocess/patch-compile-root-jdk1.8.0_74.txt | | compile | https://builds.apache.org/job/PreCommit-HADOOP-Build/8855/artifact/patchprocess/patch-compile-root-jdk1.7.0_95.txt | | cc | https://builds.apache.org/job/PreCommit-HADOOP-Build/8855/artifact/patchprocess/patch-compile-root-jdk1.7.0_95.txt | | javac | https://builds.apache.org/job/PreCommit-HADOOP-Build/8855/artifact/patchprocess/patch-compile-root-jdk1.7.0_95.txt | | checkstyle | https://builds.apache.org/job/PreCommit-HADOOP-Build/8855/artifact/patchprocess/diff-checkstyle-root.txt | | mvnsite | https://builds.apache.org/job/PreCommit-HADOOP-Build/8855/artifact/patchprocess/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt | | whitespace | https://builds.apache.org/job/PreCommit-HADOOP-Build/8855/artifact/patchprocess/whitespace-eol.txt | | findbugs | https://builds.apache.org/job/PreCommit-HADOOP-Build/8855/artifact/patchprocess/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs.txt | | unit | https://builds.apache.org/job/PreCommit-HADOOP-Build/8855/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt | | unit | https://builds.apache.org/job/PreCommit-HADOOP-Build/8855/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt | | unit | https://builds.apache.org/job/PreCommit-HADOOP-Build/8855/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt | | unit test logs | https://builds.apache.org/job/PreCommit-HADOOP-Build/8855/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt | | JDK v1.7.0_95 Test Results | https://builds.apache.org/job/PreCommit-HADOOP-Build/8855/testReport/ | | asflicense | https://builds.apache.org/job/PreCommit-HADOOP-Build/8855/artifact/patchprocess/patch-asflicense-problems.txt | | modules | C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . | | Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/8855/console | | Powered by | Apache Yetus 0.2.0 http://yetus.apache.org | This message was automatically generated. > DomainSocket: Solaris does not support timeouts on AF_UNIX sockets > ------------------------------------------------------------------ > > Key: HADOOP-12488 > URL: https://issues.apache.org/jira/browse/HADOOP-12488 > Project: Hadoop Common > Issue Type: Sub-task > Components: net > Affects Versions: 2.7.1 > Environment: Solaris > Reporter: Alan Burlison > Assignee: Alan Burlison > Attachments: HADOOP-12488.001.patch, HADOOP-12488.002.patch > > > From the hadoop-common-dev mailing list: > http://mail-archives.apache.org/mod_mbox/hadoop-common-dev/201509.mbox/%3c560b99f6.6010...@oracle.com%3E > http://mail-archives.apache.org/mod_mbox/hadoop-common-dev/201510.mbox/%3c560ea6bf.2070...@oracle.com%3E > {quote} > Now that the Hadoop native code builds on Solaris I've been chipping > away at all the test failures. About 50% of the failures involve > DomainSocket, either directly or indirectly. That seems to be mainly > because the tests use DomainSocket to do single-node testing, whereas in > production it seems that DomainSocket is less commonly used > (https://hadoop.apache.org/docs/r2.7.1/hadoop-project-dist/hadoop-hdfs/ShortCircuitLocalReads.html). > The particular problem on Solaris is that socket read/write timeouts > (the SO_SNDTIMEO and SO_RCVTIMEO socket options) are not supported for > UNIX domain (PF_UNIX) sockets. Those options are however supported for > PF_INET sockets. That's because the socket implementation on Solaris is > split roughly into two parts, for inet sockets and for STREAMS sockets, > and the STREAMS implementation lacks support for SO_SNDTIMEO and > SO_RCVTIMEO. As an aside, performance of sockets that use loopback or > the host's own IP is slightly better than that of UNIX domain sockets on > Solaris. > I'm investigating getting timeouts supported for PF_UNIX sockets added > to Solaris, but in the meantime I'm also looking how this might be > worked around in Hadoop. One way would be to implement timeouts by > wrapping all the read/write/send/recv etc calls in DomainSocket.c with > either poll() or select(). > The basic idea is to add two new fields to DomainSocket.c to hold the > read/write timeouts. On platforms that support SO_SNDTIMEO and > SO_RCVTIMEO these would be unused as setsockopt() would be used to set > the socket timeouts. On platforms such as Solaris the JNI code would use > the values to implement the timeouts appropriately. > To prevent the code in DomainSocket.c becoming a #ifdef hairball, the > current socket IO function calls such as accept(), send(), read() etc > would be replaced with a macros such as HD_ACCEPT. On platforms that > provide timeouts these would just expand to the normal socket functions, > on platforms that don't support timeouts it would expand to wrappers > that implements timeouts for them. > The only caveats are that all code that does anything to a PF_UNIX > socket would *always* have to do so via DomainSocket. As far as I can > tell that's not an issue, but it would have to be borne in mind if any > changes were made in this area. > Before I set about doing this, does the approach seem reasonable? > {quote} > {quote} > Unfortunately it's not a simple as I'd hoped. For some reason I don't > really understand, nearly all the JNI methods are declared as static and > therefore don't get a "this" pointer and as a consequence all the class > data members that are needed by the JNI code have to be passed in as > parameters. That also means it's not possible to store the timeouts in > the DomainSocket fields from within the JNI code. Most of the JNI > methods should be instance methods rather than static ones, but making > that change would require some significant surgery to DomainSocket. > {quote} -- This message was sent by Atlassian JIRA (v6.3.4#6332)