[
https://issues.apache.org/jira/browse/HADOOP-12926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15200581#comment-15200581
]
Chris Nauroth commented on HADOOP-12926:
----------------------------------------
bq. I don't have any objection to this, but I suspect it will get overwritten
next time someone bumps the lz4 version.
Yes, possibly, if we bump to a version different from r131. My reading of the
r131 source is that 64-bit detection is entirely different there, and it fixes
this problem as a side effect. Since HADOOP-12572 plans to go to r131, I think
the risk of regressing this patch is small. If something urgent like a
security fix prompts us to upgrade to a later version, but not r131, and it
does not have the reworked 64-bit detection, then the risk is there.
bq. It's possible that we're misusing the API and that's why the new version
doesn't work for us...
Agreed. My instinct is that it's more likely the bugs seen in HADOOP-12572 are
in the Hadoop code rather than the LZ4 code.
+1. I plan to commit this, but I'll wait until Friday, 3/18, in case anyone
else wants to comment.
> lz4.c does not detect 64-bit mode properly
> ------------------------------------------
>
> Key: HADOOP-12926
> URL: https://issues.apache.org/jira/browse/HADOOP-12926
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: native
> Affects Versions: 2.7.2
> Environment: All
> Reporter: Alan Burlison
> Assignee: Alan Burlison
> Attachments: HADOOP-12926.001.patch
>
>
> lz4.c should check to see if the _LP64 macro is defined to correctly detect
> when it is being built in 64-bit mode.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
