[ https://issues.apache.org/jira/browse/HADOOP-6818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12907527#action_12907527 ]
Todd Lipcon commented on HADOOP-6818: ------------------------------------- Took a look at this patch today, a few notes: - In the static initializer of JniBasedUnixGroupsMapping instead of logging Info and throwing an empty RTE, would be nice to include that message as the message of the RTE. - In the C code, rather than having a separate function to free things, maybe just use a goto to the end of the function? The forward declaration is a little odd, stylistically. - Would be good to add a comment explaining how to run the "test" in getGroup.c, as well - in getGroupDetails, probably safer to check if sysconf returns a positive number, and if not set it to something reasonable like 512. Should also probably add sizeof(struct group) to the buffer size here. Otherwise looks good. Also +1 on the simplification of the automake structure. > Provide a JNI-based implementation of GroupMappingServiceProvider > ----------------------------------------------------------------- > > Key: HADOOP-6818 > URL: https://issues.apache.org/jira/browse/HADOOP-6818 > Project: Hadoop Common > Issue Type: Improvement > Components: security > Reporter: Devaraj Das > Assignee: Devaraj Das > Fix For: 0.22.0 > > Attachments: hadoop-6818-1.patch, hadoop-6818-2.patch, > JNIGroupMapping.patch > > > The default implementation of GroupMappingServiceProvider does a fork of a > unix command to get the groups of a user. Since the group resolution happens > in the servers, this might be costly. This jira aims at providing a JNI-based > implementation for GroupMappingServiceProvider. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.