[ https://issues.apache.org/jira/browse/HADOOP-11393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15213859#comment-15213859 ]
Akira AJISAKA commented on HADOOP-11393: ---------------------------------------- Mostly looks good to me. Minor nit: * Duplicate {{unset HADOOP_HOME}} in hadoop-functions_test_helper.bash. > Revert HADOOP_PREFIX, go back to HADOOP_HOME > -------------------------------------------- > > Key: HADOOP-11393 > URL: https://issues.apache.org/jira/browse/HADOOP-11393 > Project: Hadoop Common > Issue Type: Improvement > Components: scripts, tracing > Affects Versions: 3.0.0 > Reporter: Allen Wittenauer > Assignee: Allen Wittenauer > Attachments: HADOOP-11393-00.patch, HADOOP-11393.01.patch, > HADOOP-11393.02.patch, HADOOP-11393.03.patch, HADOOP-11393.04.patch > > > Today, Windows and parts of the Hadoop source code still use HADOOP_HOME. > The switch to HADOOP_PREFIX back in 0.21 or so didn't really accomplish what > it was intended to do and only helped confuse the situation. > _HOME is a much more standard suffix and is, in fact, used for everything in > Hadoop except for the top level project home. I think it would be beneficial > to use HADOOP_HOME in the shell code as the Official(tm) variable, still > honoring HADOOP_PREFIX if it is set. -- This message was sent by Atlassian JIRA (v6.3.4#6332)