[ 
https://issues.apache.org/jira/browse/HADOOP-12972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15217620#comment-15217620
 ] 

John Zhuge commented on HADOOP-12972:
-------------------------------------

If we want to match Hadoop lz4 library version with OS lz4 command version, 
shall we make the following change instead of Patch 001?
{code}
Java_org_apache_hadoop_io_compress_lz4_Lz4Compressor_getLibraryName(
  JNIEnv *env, jclass class
  ) {
  return (*env)->NewStringUTF(env, "r123");
}
{code}
If we take this approach, we must add comments reminding whoever upgrades LZ4 
revision to update this hardcoded value.

> Lz4Compressor#getLibraryName returns the wrong version number
> -------------------------------------------------------------
>
>                 Key: HADOOP-12972
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12972
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: native
>    Affects Versions: 2.6.0
>            Reporter: John Zhuge
>            Assignee: Colin Patrick McCabe
>            Priority: Trivial
>             Fix For: 2.8.0
>
>         Attachments: HADOOP-12972.001.patch
>
>
> HADOOP-11184 updated lz4 to "r123", but {{hadoop checknative -a}} still 
> prints "revision:99".
> {code}
> $ hadoop checknative -a
> 16/03/29 11:42:40 INFO bzip2.Bzip2Factory: Successfully loaded & initialized 
> native-bzip2 library system-native
> 16/03/29 11:42:40 INFO zlib.ZlibFactory: Successfully loaded & initialized 
> native-zlib library
> Native library checking:
> hadoop:  true 
> /opt/cloudera/parcels/CDH-5.8.0-1.cdh5.8.0.p0.1209/lib/hadoop/lib/native/libhadoop.so.1.0.0
> zlib:    true /lib64/libz.so.1
> snappy:  true 
> /opt/cloudera/parcels/CDH-5.8.0-1.cdh5.8.0.p0.1209/lib/hadoop/lib/native/libsnappy.so.1
> lz4:     true revision:99
> bzip2:   true /lib64/libbz2.so.1
> openssl: true /usr/lib64/libcrypto.so
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to