[
https://issues.apache.org/jira/browse/HADOOP-12892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15236415#comment-15236415
]
Andrew Wang commented on HADOOP-12892:
--------------------------------------
Thanks for the rev Allen, sorry for not getting to this sooner. Some review
comments:
* Typo "relase" in help text and the docker imgname
* Shall we change "patchprocess" to "releaseprocess" or some such for LOGDIR?
* --asfrelease sets NATIVE and SIGN, so the "--asfrelease requires --sign"
validation will never trigger
* Should we even support building on Darwin? I'd rather it just abort for
unsupported platforms. Is windows supported for that matter?
* The docker run command will pass along --dockercache, which then prints a
spurious error msg:
{noformat}
$ docker run -i -t --privileged -v /home/andrew/.gnupg:/home/andrew/.gnupg -v
/home/andrew/dev/apache/trunk/patchprocess:/home/andrew/dev/apache/trunk/patchprocess
-v
/home/andrew/dev/apache/trunk/target/artifacts:/home/andrew/dev/apache/trunk/target/artifacts
-v /home/andrew/dev/apache/trunk:/build/source -u andrew -w /build/source
hadoop/createrelase:3.0.0-SNAPSHOT_norc
/build/source/dev-support/bin/create-release --mvncache=/maven --asfrelease
--dockercache --indocker
ERROR: docker mode not enabled. Disabling dockercache.
{noformat}
* DOCKERAN isn't set anywhere, remove this check?
* MVNCACHE is ignored when --dockercache is specified and not --indocker right?
That would be a good validation.
* Nit: some extra newlines at the end of makearelease
* When I did --asfrelease with --docker, it hung without output waiting for my
GPG passphrase. I typed in my PW a few times, but it kept prompting, possibly
because there wasn't a GPG agent running. Ended up Ctrl-D'ing it.
* Related to previous, it'd be nice to be able to do --sign independent of the
build. Means we should filter out ".asc" and ".mds" files in signartifacts in
case it's invoked twice though. I moved signartifacts out of its if statement
as a test, which worked.
> fix/rewrite create-release
> --------------------------
>
> Key: HADOOP-12892
> URL: https://issues.apache.org/jira/browse/HADOOP-12892
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Reporter: Allen Wittenauer
> Assignee: Allen Wittenauer
> Priority: Blocker
> Attachments: HADOOP-12892.00.patch, HADOOP-12892.01.patch
>
>
> create-release needs some major surgery.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
