[ https://issues.apache.org/jira/browse/HADOOP-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15245676#comment-15245676 ]
Naganarasimha G R commented on HADOOP-13035: -------------------------------------------- Hi [~bibinchundatt], if you have a patch for this, please upload so that we can cross verify how many failures and evaluate the risk with this change. > AbstractService should set state only after state change > -------------------------------------------------------- > > Key: HADOOP-13035 > URL: https://issues.apache.org/jira/browse/HADOOP-13035 > Project: Hadoop Common > Issue Type: Bug > Reporter: Bibin A Chundatt > > As per the discussion in YARN-3971 the we should be setting the service state > to STARTED only after serviceStart() > Currently {{AbstractService#start()}} is set > {noformat} > if (stateModel.enterState(STATE.STARTED) != STATE.STARTED) { > try { > startTime = System.currentTimeMillis(); > serviceStart(); > .. > } > {noformat} > enterState sets the service state to proposed state. So in > {{service.getServiceState}} in {{serviceStart()}} will return STARTED . -- This message was sent by Atlassian JIRA (v6.3.4#6332)