[ 
https://issues.apache.org/jira/browse/HADOOP-12985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15249271#comment-15249271
 ] 

Jitendra Nath Pandey commented on HADOOP-12985:
-----------------------------------------------

The patch looks good to me. A minor comment that NameValuePair and TopN seem 
generally useful, might make sense to move them to MetricsUtil or a separate 
class.

> Support MetricsSource interface for DecayRpcScheduler Metrics
> -------------------------------------------------------------
>
>                 Key: HADOOP-12985
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12985
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Xiaoyu Yao
>            Assignee: Xiaoyu Yao
>         Attachments: HADOOP-12985.00.patch, HADOOP-12985.02.patch, 
> HADOOP-12985.03.patch
>
>
> This allows metrics collector such as AMS to collect it with MetricsSink. The 
> per user RPC call counts, schedule decisions and per priority response time 
> will be useful to detect and trouble shoot Hadoop RPC server such as Namenode 
> overload issues. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to