[ https://issues.apache.org/jira/browse/HADOOP-13098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15272639#comment-15272639 ]
Xiaoyu Yao edited comment on HADOOP-13098 at 5/5/16 5:05 PM: ------------------------------------------------------------- Patch v2 looks good to me. Only one minor issue in the test as shown below. +1 after that is addressed. {code} 46 Assert.assertNotEquals("Get default Log Level which shouldn't be ERROR.", 47 Level.ERROR.equals(log.getEffectiveLevel())); {code} should be {code} 46 Assert.assertNotEquals("Get default Log Level which shouldn't be ERROR.", 47 Level.ERROR, log.getEffectiveLevel()); {code} was (Author: xyao): Patch v2 looks good to me. Only one minor issue in the test as shown below. +1 after that is addressed. {code} 46 Assert.assertNotEquals("Get default Log Level which shouldn't be ERROR.", 47 Level.ERROR.equals(log.getEffectiveLevel())); {code} should be 46 Assert.assertNotEquals("Get default Log Level which shouldn't be ERROR.", 47 Level.ERROR, log.getEffectiveLevel()); > Dynamic LogLevel setting page should accept log level string with mixing > upper case and lower case > -------------------------------------------------------------------------------------------------- > > Key: HADOOP-13098 > URL: https://issues.apache.org/jira/browse/HADOOP-13098 > Project: Hadoop Common > Issue Type: Bug > Reporter: Junping Du > Assignee: Junping Du > Attachments: HADOOP-13098-v2.patch, HADOOP-13098.patch > > > Our current logLevel settings: http://deamon_web_service_address/logLevel > only accept full Upper Case string of log level that means "Debug" or "debug" > is treated as bad log level in setting. I think we should enhance the tools > to ignore upper/lower cases. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org