[ 
https://issues.apache.org/jira/browse/HADOOP-6728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917138#action_12917138
 ] 

Eric Yang commented on HADOOP-6728:
-----------------------------------

The code looks ok.  Is it is standard to do package version in the package name 
for Hadoop?

I prefer to have the code in *org.apache.hadoop.metrics* to avoid package 
version in the package name.

Otherwise +1 on the patch.

> Overhaul metrics framework
> --------------------------
>
>                 Key: HADOOP-6728
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6728
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 0.20.2
>            Reporter: Luke Lu
>            Assignee: Luke Lu
>             Fix For: 0.22.0
>
>         Attachments: hadoop-6728-y20.104.patch, metrics1-flow.png, 
> metrics2-builder-r2.png, metrics2-builder.png, metrics2-flow.png, 
> metrics2-mutable-r2.png, metrics2-mutable.png, metrics2-record-r2.png, 
> metrics2-record.png, metrics2-uml-r2.png, metrics2-uml.png
>
>
> Per discussions with Arun, Chris, Hong and Rajiv, et al, we concluded that 
> the current metrics framework needs an overhaul to:
> * Allow multiple plugins for different monitoring systems simultaneously (see 
> also: HADOOP-6508).
> * Refresh metrics plugin config without server restart.
> ** Including filtering of metrics per plugin.
> * Support metrics schema for plugins.
> The jira will be resolved when core hadoop components (hdfs, mapreduce) are 
> updated to use the new framework . Updates to external components that use 
> the existing metrics framework will be tracked by different issues.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to