[ https://issues.apache.org/jira/browse/HADOOP-12709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15274816#comment-15274816 ]
Chris Nauroth commented on HADOOP-12709: ---------------------------------------- Hello [~liuml07]. Thank you for taking care of this. This looks good overall. bq. Did I miss anything? The only missing thing I noticed is that we should remove the {{fs.s3.*}} properties from core-default.xml. > Deprecate s3:// in branch-2,; cut from trunk > -------------------------------------------- > > Key: HADOOP-12709 > URL: https://issues.apache.org/jira/browse/HADOOP-12709 > Project: Hadoop Common > Issue Type: Improvement > Components: fs/s3 > Affects Versions: 2.8.0 > Reporter: Steve Loughran > Assignee: Mingliang Liu > Attachments: HADOOP-12709.000.patch > > > The fact that s3:// was broken in Hadoop 2.7 *and nobody noticed until now* > shows that it's not being used. while invaluable at the time, s3n and > especially s3a render it obsolete except for reading existing data. > I propose > # Mark Java source as {{@deprecated}} > # Warn the first time in a JVM that an S3 instance is created, "deprecated > -will be removed in future releases" > # in Hadoop trunk we really cut it. Maybe have an attic project (external?) > which holds it for anyone who still wants it. Or: retain the code but remove > the {{fs.s3.impl}} config option, so you have to explicitly add it for use. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org