[
https://issues.apache.org/jira/browse/HADOOP-12709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mingliang Liu updated HADOOP-12709:
-----------------------------------
Attachment: HADOOP-12709.004.patch
Thanks [~cnauroth] for your review and nice catches. Sorry I missed the places
out of the {{hadoop-aws}} module. In the current patch, all the clean-ups you
listed are addressed. The checkstyle and javadoc warnings are fixed as well.
Thanks [~ste...@apache.org] for the review and comment. I was kind of
aggressive about changing the config keys/values, but I agree that if we should
keep the original names and mark them as deprecated if we can. This way, the
existing applications using s3n don't have to update their configurations to
run. As to the implementation, the v4 patch employs the
{{Configuration#addDeprecations}} in the static block. I'm wondering if there
is a better way.
Your 2nd and 3rd comments are very valid though I was thinking of addressing
them separately along with other existing places where inline strings were
used. As those changes are very related but not complex, I also think it's
doable in this patch. See v4 if I address them correctly.
> Deprecate s3:// in branch-2,; cut from trunk
> --------------------------------------------
>
> Key: HADOOP-12709
> URL: https://issues.apache.org/jira/browse/HADOOP-12709
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs/s3
> Affects Versions: 2.8.0
> Reporter: Steve Loughran
> Assignee: Mingliang Liu
> Attachments: HADOOP-12709.000.patch, HADOOP-12709.001.patch,
> HADOOP-12709.002.patch, HADOOP-12709.003.patch, HADOOP-12709.004.patch
>
>
> The fact that s3:// was broken in Hadoop 2.7 *and nobody noticed until now*
> shows that it's not being used. while invaluable at the time, s3n and
> especially s3a render it obsolete except for reading existing data.
> I propose
> # Mark Java source as {{@deprecated}}
> # Warn the first time in a JVM that an S3 instance is created, "deprecated
> -will be removed in future releases"
> # in Hadoop trunk we really cut it. Maybe have an attic project (external?)
> which holds it for anyone who still wants it. Or: retain the code but remove
> the {{fs.s3.impl}} config option, so you have to explicitly add it for use.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
