[ 
https://issues.apache.org/jira/browse/HADOOP-13112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matthew Paduano updated HADOOP-13112:
-------------------------------------
    Attachment: HADOOP-13112.04.patch

Patch 04 addresses the merge issue from HADOOP-12942

{code}
for patch #04:
 .../org/apache/hadoop/crypto/key/KeyShell.java     |  180 +++++++-------------
 .../hadoop/security/alias/CredentialShell.java     |  176 ++++++++------------
 .../java/org/apache/hadoop/tools/CommandShell.java |    4 
 3 files changed, 136 insertions(+), 224 deletions(-)
-------------------------------------------------------
T E S T S
-------------------------------------------------------
Running org.apache.hadoop.crypto.key.TestKeyShell
 Tests run: 10, Failures: 0, Errors: 0, Skipped: 0
Running org.apache.hadoop.security.alias.TestCredShell
 Tests run: 12, Failures: 0, Errors: 0, Skipped: 0
Running org.apache.hadoop.security.token.TestDtUtilShell
 Tests run: 8, Failures: 0, Errors: 0, Skipped: 0
Running org.apache.hadoop.tools.TestCommandShell
 Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
Results: Tests run: 31, Failures: 0, Errors: 0, Skipped: 0
{code}

> Change CredentialShell to use CommandShell base class
> -----------------------------------------------------
>
>                 Key: HADOOP-13112
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13112
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Matthew Paduano
>            Assignee: Matthew Paduano
>            Priority: Minor
>         Attachments: HADOOP-13112.01.patch, HADOOP-13112.02.patch, 
> HADOOP-13112.03.patch, HADOOP-13112.04.patch
>
>
> org.apache.hadoop.tools.CommandShell is a base class created for use by 
> DtUtilShell.  It was inspired by CredentialShell and much of it was taken 
> verbatim.  It should be a simple change to get CredentialShell to use the 
> base class and simplify its code without changing its functionality.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to